"rows" is defaulted to just spaces #72699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
github-actions
bot
added
json-styled
|
could you remove this thing also? Cataclysm-DDA/data/json/mapgen/debug.json Lines 8 to 33 in dd4e109 |
github-actions
bot
added
Missions
Procyonae
changed the title
github-actions
bot
added
the
BasicBuildPassed
github-actions
bot
removed
the
BasicBuildPassed
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @LyleSY @Standing-Storm
github-actions
bot
added
<Documentation>
|
I think Flexbuffers is an akrieger word |
akrieger
reviewed
Apr 2, 2024
Excessive amount of errors just because otherwise you get a gibberish one
github-actions
bot
removed
the
BasicBuildPassed
akrieger
approved these changes
Apr 3, 2024
github-actions
bot
added
the
BasicBuildPassed
|
Oh, nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes #72511
Describe the solution
If "rows" isn't provided a row of the expected size of just spaces is used every time one is expected
Removes existing blank "rows" no longer needed
Describe alternatives you've considered
Testing
Compiles and seems to work
Additional context
Most of the c++ change shown is just whitespace idk why git is highlighting the whole thing