Fix negative rest quality #72892
Merged
Fix negative rest quality #72892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
github-actions
bot
added
json-styled
Procyonae
added
the
0.H Backport
Procyonae
pushed a commit
to Procyonae/Cataclysm-DDA
that referenced
this pull request
May 24, 2024
…t_V2 Fix negative rest quality
Merged
kevingranade
pushed a commit
that referenced
this pull request
May 26, 2024
Fix negative rest quality Co-authored-by: RenechCDDA <84619419+RenechCDDA@users.noreply.github.com>
Procyonae
added
0.H Backported
and removed
0.H Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Rest quality is not always positive, negative rest quality will slow your bandaged healing "
Purpose of change
Describe the solution
Character::activity_level() always returns NO_EXERCISE except when sleeping, which meant that even while digging ditches it thought you were resting peacefully. This gave 30-50% faster medicine healing, for everyone, always. Yikes.
I do not really understand why it does that, but switching to Character::instantaneous_activity_level() returns the actual activity level... So that was an easy swap.
Other change: Unclamp rest quality in healing_rate_medicine so negative rest quality actually detracts from your healing.
Update docs to mention how rest quality works.
Describe alternatives you've considered
#68395
Testing
Healing tests pass locally, some extra-extra debug output (not present in commit) was doubly, triply checked to make sure the healing_rate_medicine was changing.
Additional context