calorie related math effect #73136
Merged
calorie related math effect #73136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
GuardianDll
force-pushed
the
calorie_math
branch
from
4bcd9a4
to
e15ae89
Compare
github-actions
bot
added
<Documentation>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @Standing-Storm @Venera3 @andrei8l
GuardianDll
force-pushed
the
calorie_math
branch
from
199dbc5
to
6608e7c
Compare
mqrause
reviewed
Apr 20, 2024
Co-authored-by: mqrause <38702195+mqrause@users.noreply.github.com>
github-actions
bot
removed
the
astyled
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
astyled
github-actions
bot
added
the
Code: Tests
github-actions
bot
added
the
BasicBuildPassed
Co-authored-by: anothersimulacrum <anothersimulacrum@gmail.com>
github-actions
bot
removed
the
BasicBuildPassed
…the returns in the function. better approach would be divide this function in two, one for raw value that return int, one for percent value that return double or function that return healthy kcal directly
Co-authored-by: anothersimulacrum <anothersimulacrum@gmail.com>
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Tried to add a way for math to read item calorie content, decided the best approach would be moving entire dialogue condition to the math
Describe the solution
make a math function
calories(), that containstored_kcal(ascalories()orcalories('format': 'raw')), stored_kcal_percentage (ascalories('format': 'percent')) and also can read the caloric content of the item, if one of the talkers is itemTesting
Additional context
Albeit wonky, it worked before, but then i was told if i want optional options, i need to use kwargs instead of params, and when i changed it, it stopped working with items, which was kinda the point of all of itit worked, i just didn't use the proper EoC, duh