-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eeeeven MOOORE mission context dialogue for Liam. #73184
Merged
Maleclypse
merged 11 commits into
CleverRaven:master
from
I-am-Erk:still-more-liam-dialogue-will-it-never-end
Apr 24, 2024
Merged
Eeeeven MOOORE mission context dialogue for Liam. #73184
Maleclypse
merged 11 commits into
CleverRaven:master
from
I-am-Erk:still-more-liam-dialogue-will-it-never-end
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes a 'secret crush' easter egg.
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
Apr 22, 2024
DSeyka
reviewed
Apr 22, 2024
Co-authored-by: DSeyka <66876732+DSeyka@users.noreply.github.com>
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Apr 22, 2024
…github.com/i-am-erk/Cataclysm-DDA into still-more-liam-dialogue-will-it-never-end
github-actions
bot
removed
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Apr 22, 2024
Adds meeting variables to the artisans too
DSeyka
reviewed
Apr 23, 2024
DSeyka
reviewed
Apr 23, 2024
Thanks for the proofread DSeyka Co-authored-by: DSeyka <66876732+DSeyka@users.noreply.github.com>
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
NPC / Factions
NPCs, AI, Speech, Factions, Ownership
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Eeeeven MOOORE mission context dialogue for Liam (Friends to the End)."
Purpose of change
#73108 and #73133 added a whole ton of mission-specific dialogue for Liam. This continues the job.
Describe the solution
Adds:
Adds a meeting variable to the artisans, as well
More to come, watch this space. For this PR I'd like to try to get all the quests that originate inside the refugee center - the doctor, the arsonist, etc etc.
As always, my primary intention here is to create a sort of template that I can use to create similar dialogue for other major NPCs. The work load should be far lower to do this for a second batch.
Describe alternatives you've considered
Living life in darkness, devoid of finding out Liam's secret crush.
Testing
TK
Additional context
I realized that there is a fairly large contingent of missions that won't need responses, like base camp stuff, so this job may be more attainable than I thought.
I probably am going to need to break up the chat file again, it's getting huge.