Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eeeeven MOOORE mission context dialogue for Liam. #73184

Conversation

I-am-Erk
Copy link
Member

@I-am-Erk I-am-Erk commented Apr 22, 2024

Summary

Content "Eeeeven MOOORE mission context dialogue for Liam (Friends to the End)."

Purpose of change

#73108 and #73133 added a whole ton of mission-specific dialogue for Liam. This continues the job.

Describe the solution

Adds:

  • Dialogue for all the surface refugee quests at the Free Merchant center
  • You can find out Liam's secret crush! If someone implements #73140 for me, I'll try to add other ways to find out, and even something you can do about it.
  • The rest of Smokes' quests
  • The Broker's pickle quest and a few other odd jobs around the center
  • Dino dave quests
  • Science rep quests

Adds a meeting variable to the artisans, as well

More to come, watch this space. For this PR I'd like to try to get all the quests that originate inside the refugee center - the doctor, the arsonist, etc etc.

As always, my primary intention here is to create a sort of template that I can use to create similar dialogue for other major NPCs. The work load should be far lower to do this for a second batch.

Describe alternatives you've considered

Living life in darkness, devoid of finding out Liam's secret crush.

Testing

TK

Additional context

I realized that there is a fairly large contingent of missions that won't need responses, like base camp stuff, so this job may be more attainable than I thought.

I probably am going to need to break up the chat file again, it's getting huge.

Includes a 'secret crush' easter egg.
@I-am-Erk I-am-Erk added the NPC / Factions NPCs, AI, Speech, Factions, Ownership label Apr 22, 2024
@github-actions github-actions bot added the [JSON] Changes (can be) made in JSON label Apr 22, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 22, 2024
Co-authored-by: DSeyka <66876732+DSeyka@users.noreply.github.com>
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 22, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 22, 2024
@I-am-Erk I-am-Erk marked this pull request as ready for review April 22, 2024 19:51
Thanks for the proofread DSeyka

Co-authored-by: DSeyka <66876732+DSeyka@users.noreply.github.com>
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • &He looks at you, a bit surprised. "Yeah, of course. I mean, that situation they're in now is miserable, no matter how much we've helped folks out there. Can you imagine trying to be a young couple in that cramped space?" He waggles his eyebrows suggestively. "They're tryin' to have a baby, you know. Gonna be hard in a bunkhouse. Let's get them out to a nice farm, some fresh air, and, you know." He winks, to drive the point far, far further home than necessary. "Let the magic happen, right?"
  • Fast, unidentified monsters are killing the local wildlife, and we're going to get 'em." He looks thoughtful. "I'm pretty sure this was an episode of the X-Files. Or like, several episodes? As long as we're Scully and Mulder we'll be fine, but if we're the local cops coming in to investigate, we're toast. Just in case, let's make sure we've got our good gear.
  • Of course! People need what comfort they can get, right? I've always been kinda spiritual, but I'm not the sort to put a label on it or anything. I don't have a clue where to find one though, I'm not sure I'd even recognize a mosque if I saw one. Do they stock books like that in normal stores?" He frowns. "I feel like I should know this, but… well, no Wikipedia, right?
  • Well, it probably isn't going to come back alive. They ooze blood everywhere, when we fight 'em. It's kinda thicker and goopier than human blood, but I guess not so bad it'd be hard to draw?
  • Will do, Scully. I'd like your opinion on something else.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 23, 2024
@Maleclypse Maleclypse merged commit f733682 into CleverRaven:master Apr 24, 2024
18 of 24 checks passed
@I-am-Erk I-am-Erk deleted the still-more-liam-dialogue-will-it-never-end branch April 24, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants