Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extra Mutated Scenarios ] Adds new mutation trees to mod starts #73290

Merged
merged 15 commits into from
May 3, 2024

Conversation

Hellcommander
Copy link
Contributor

@Hellcommander Hellcommander commented Apr 26, 2024

Summary

Mods "[Extra Mutated Scenarios] Update to include new mutation lines"

Purpose of change
To update the mod to include the newer mutations and resolves issues like allowing players to give a mutant that doesn't have the right threshold a mutation that requires something they don't have.

Describe the solution
Manually updated it to allow people to be to choose newer mutations, prevent getting a threshold mutation that you are not at the threshold for, prevent being able to select a mutation that is flagged as invalid (it was part of a condition mutation that triggered it based on mood) and prevent issues like selecting a mutation but being given a different mutation instead though this still happens (things would likely have to change in the code to fix this)

Describe alternatives you've considered
Testing
I've used it for multiple characters with no issues

Additional context
Didn't know how to implement the wildcard thing for chimera so threshold mutations are still limited to chimera on character gen

Copy link
Contributor

You are creating a pull request with the master branch as the head branch. This is likely a mistake unless you really know what you are doing. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Apr 26, 2024
data/mods/extra_mut_scen/mutation_scenarios.json Outdated Show resolved Hide resolved
data/mods/extra_mut_scen/mutation_scenarios.json Outdated Show resolved Hide resolved
data/mods/extra_mut_scen/mutation_scenarios.json Outdated Show resolved Hide resolved
data/mods/extra_mut_scen/mutation_scenarios.json Outdated Show resolved Hide resolved
data/mods/extra_mut_scen/mutation_scenarios.json Outdated Show resolved Hide resolved
data/mods/extra_mut_scen/mutation_scenarios.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Apr 26, 2024
data/mods/extra_mut_scen/mutation_scenarios.json Outdated Show resolved Hide resolved
data/mods/extra_mut_scen/mutation_scenarios.json Outdated Show resolved Hide resolved
data/mods/extra_mut_scen/mutation_scenarios.json Outdated Show resolved Hide resolved
data/mods/extra_mut_scen/mutation_scenarios.json Outdated Show resolved Hide resolved
data/mods/extra_mut_scen/mutation_scenarios.json Outdated Show resolved Hide resolved
data/mods/extra_mut_scen/mutation_scenarios.json Outdated Show resolved Hide resolved
data/mods/extra_mut_scen/mutation_scenarios.json Outdated Show resolved Hide resolved
data/mods/extra_mut_scen/mutation_scenarios.json Outdated Show resolved Hide resolved
@Zireael07
Copy link
Contributor

Please clarify PR title - what is 'this mod'?

@Procyonae
Copy link
Contributor

Procyonae commented Apr 26, 2024

You're not meant to just delete the template and start over the changelog bot won't recognise your first line which should be something like

#### Summary
Mods "[Extra Mutated Scenarios] Update to include new mutation lines"

@Hellcommander
Copy link
Contributor Author

thanks

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 26, 2024
@Maleclypse Maleclypse changed the title Updated this mod to include recent changes from last time it was updated and reformatted scenarios to look cleaner and more easy to update [Extra Mutated Scenarios ] Adds new mutation trees to mod starts Apr 29, 2024
@github-actions github-actions bot added the Items: Armor / Clothing Armor and clothing label Apr 29, 2024
data/json/items/armor/integrated.json Outdated Show resolved Hide resolved
data/json/items/armor/integrated.json Outdated Show resolved Hide resolved
data/json/items/armor/integrated.json Outdated Show resolved Hide resolved
changes to intergrated is mostly to make sure hard chitin and bark intergrated armor does not block large talons (during testing character did not seem to use the talons while unarmed with a bark type mutation and especially with chitin plate) and added padded to bark and chitin to prevent possible armor running against skin (seen the issue before when having character start with just chitin plate) since discord subjected I apply the fix to base game instead of making a mod to apply the fix (can easily make as mod since fix only applies tags and should have not impact on stuff besides fixed use cases and increasing file size slightly)
@Procyonae
Copy link
Contributor

Why have you duped the integrated file?

@Hellcommander
Copy link
Contributor Author

sorry missed it was using it to compare if there was changes updated branch with it removed

…cked behind thresholds

removed Infrared Vision from pre threshold chooses since it is now locked behind thresholds
Copy link
Member

@GuardianDll GuardianDll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me

@Maleclypse Maleclypse merged commit abe3f76 into CleverRaven:master May 3, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Extra Mutated Scenarios Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants