Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in exodii_merchant_talk.json #73385

Conversation

SomeGuyIGues
Copy link
Contributor

@SomeGuyIGues SomeGuyIGues commented Apr 29, 2024

Summary

Bugfixes "A typo within exodii_merchant_talk.json made Rubik give the player the silent treatment for quests. This fixes that."

Purpose of change

A typo within exodii_merchant_talk.json made Rubik give the player the silent treatment for quests. This fixes that. Fixes #73340

Describe the solution

Changed the id on line 356 from "TALK_EXODII_MERCHANT_TalkJobs" to "TALK_EXODII_MERCHANT_TalkJob"

Describe alternatives you've considered

Change lines 39 and 156 from "TALK_EXODII_MERCHANT_TalkJob" to "TALK_EXODII_MERCHANT_TalkJobs." But why in God's holy name would I do that?

Testing

Step 0. Rubik refuses to talk to me.
Step 1. Fix the issue.
Step 2. They've opened up and are now opening me up (literally). Great success!

Additional context

Fixed line 356 id from "TALK_EXODII_MERCHANT_TalkJobs" to "TALK_EXODII_MERCHANT_TalkJob."
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) new contributor labels Apr 29, 2024
@SomeGuyIGues SomeGuyIGues changed the title Update exodii_merchant_talk.json Fix typo in exodii_merchant_talk.json Apr 29, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 29, 2024
@I-am-Erk I-am-Erk merged commit 5590543 into CleverRaven:master May 1, 2024
20 of 30 checks passed
@SomeGuyIGues SomeGuyIGues deleted the Fixed-typo-in-exodii_merchant_talk.json branch May 1, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rubik's dialogue line "I'm here to talk about a job." is broken - typo in JSON
2 participants