-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new hairstyles from Mawranth's Hair Salon #73465
Conversation
Co-authored-by: Mawranth <168459051+Mawranth@users.noreply.github.com>
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
Out of scope here, but I'm wondering if access to this isn't something that could be tied to the Boston Anime Con magazine. At the very least it could be something you bring to the refugee center hairstylist to unlock those styles. |
hairstyles are entirely cosmetic, so there's no reason to limit what hairstyles you can have by specific prerequisites. If you can start the game with purple or green hair, anime styles themselves also aren't really that much of a leap. Limiting their spawns on npcs is fine though, that way it's all opt in for the player and their followers. |
I don't see how them being cosmetic necessarily prevents making them interact with systems. If you want them available at chargen you could for instance hook them into the cosplay background or the otaku profession. |
d737483
to
91a8ff7
Compare
Summary
Features "Add new hairstyles from Mawranth's Hair Salon"
Purpose of change
@Mawranth posted a few gorgeous sprites in the form of a mod. Those absolutely deserve to be in the base game but they need the data to host them first, this PR aims to add it.
Describe the solution
Checked Mawranth's implementation fixed it a little, formatted it correctly, added bells and whistles such as integration into the new hair growth system and npc distribution.
Describe alternatives you've considered
I am a bit torn on the pop references hairstyles (super princess, detective and twintails), for the time being they're being added as "normal" hairstyles but maybe they should be restricted to haircutting only, maybe they shouldn't spawn on npcs. I'll add them in a single commit so we can revert it just in case. Feel free to help me decide on the way they should be implemented, I need higher-up input here.
Testing
Spawned in game, mutated the different hair styles, seems to work fine.
Additional context
ALL CREDITS SHOULD GO TO @Mawranth. They wrote the descriptions, the names, had the original idea and everything, I am merely making the implementation easier on them.
The PR for the sprites can be found there.
I aim to do in this PR the same thing done in #61940 basically.