Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish fry & tadpole minor audit #73528

Merged
merged 3 commits into from
May 10, 2024
Merged

Conversation

Karol1223
Copy link
Contributor

Summary

None

Purpose of change

These guys both were lacking in some departments

Describe the solution

Fish fry

  • got a defined harvestlist of exempt - honestly not sure if this causes anything, but I am foolproofing this in case someone someday gets their corpse on their hands somehow
  • got basic biology and physiology proficiencies - both normal fry and mutant fry (which should matter for the mutant)
  • shrunk volume from 10ml to 3ml
  • lowered mutant fry dodge from 10 to 8

Tadpoles

  • increased dodge from 5 to 10
  • no longer drop corpses - seriously, those guys are too small for this
  • shrunk even more
  • removed fire fear trigger - not for an aquatic critter

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 5, 2024
@fairyarmadillo
Copy link
Contributor

The fry should probably have 0 dodge, like other fish. Its tinyness will already make it very hard to hit, and at 8 dodge, the definitive meta for training melee will be to find one of these harmless creatures and spam attacks at it forever.

@Karol1223
Copy link
Contributor Author

The fry should probably have 0 dodge, like other fish. Its tinyness will already make it very hard to hit, and at 8 dodge, the definitive meta for training melee will be to find one of these harmless creatures and spam attacks at it forever.

Doesn't melee training depend on monster difficulty/melee skill level? These have the minimal amount of both, so this shouldn't matter.

@fairyarmadillo
Copy link
Contributor

I was under the impression it was dodge skill. If I'm mistaken then nevermind.

@Karol1223 Karol1223 marked this pull request as draft May 8, 2024 10:34
@Karol1223
Copy link
Contributor Author

After some research (asking people smarter than me if I was wrong or not):

  • Dodge doesn't affect training melee skills
  • Melee skill level of monster does, and this skill can't go below 1 to my knowledge => you can learn up to skill level 3 on fish fry
  • This is fixable by manually defining a field with maximum level the monster can teach you up to. I'll do that in the evening for fish and frogs

@Karol1223 Karol1223 marked this pull request as ready for review May 8, 2024 17:46
@I-am-Erk I-am-Erk merged commit 5f72fbe into CleverRaven:master May 10, 2024
26 of 31 checks passed
@Karol1223 Karol1223 deleted the tadpomls branch May 11, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants