Made a change to the popup to fix text being cut off at low resolutions. #73678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Bugfix>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
json-styled
katemonster33
force-pushed
the
imgui_popup_text_cutoff
branch
from
1c6dcff
to
79f7028
Compare
github-actions
bot
added
BasicBuildPassed
GuardianDll
added a commit
to GuardianDll/Cataclysm-DDA
that referenced
this pull request
May 15, 2024
Squashed commit: [795be74] TamableWildlife Skunk Friends (CleverRaven#73645) [b345d8e] Made a change to the popup to fix text being cut off at low resolutions. (CleverRaven#73678) [0a771f6] [Magiclysm] New joke spell (CleverRaven#73251) * Spell creation plus scroll plus addition to existing book plus spawn for scroll * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> * fix ellipsis * fix formatting error --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com> [9017632] Increase feral clairsentient dodge [0adfdf1] [MoM] Normalize feral biokinetic HP (CleverRaven#73635) * Fix HP * Fix HP [1a8080a] Added Bronze Wood Saw to Misc Repair Kit Craft (CleverRaven#73654) [59351db] #include vector in cata_imgui.h (CleverRaven#73681) [cabc0eb] style [e876fae] Provided 3D camp construction + Livestock 2 example [bc9c909] Use dummy parser for attack_vector to fix string extraction script error (CleverRaven#73659) [15c4984] typified animation.cpp (CleverRaven#73609) [548059a] test
SurFlurer
added a commit
to SurFlurer/Cataclysm-DDA
that referenced
this pull request
Aug 26, 2024
…esolutions. (CleverRaven#73678)" This reverts commit b345d8e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Tutorial screen popup text no longer cuts off"
Purpose of change
Fixes: #73367
Describe the solution
Disable word wrapping on the ImGui drawing side, instead relying on the foldstring method to perform those calculations ahead of time, this reduces CPU usage while also fixing the issue.
Describe alternatives you've considered
Testing
Load tutorial, verify that at lowest resolution, the tutorial text is no longer cutoff.
Additional context