Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Rework Combat Sense with modern enchants #73727

Merged
merged 1 commit into from
May 13, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented May 12, 2024

Summary

Mods "[MoM] Rework Combat Sense with modern enchants"

Purpose of change

When I originally made the Combat Sense effect, BONUS_DODGE and BONUS_BLOCK were the only defense-increasing enchantments. That's not true anymore.

Describe the solution

Change BONUS_DODGE and BONUS_BLOCK to EVASION and DODGE_CHANCE. EVASION provides a flat chance to dodge any attack, replicating the extra defenses from the old version and also allowing you to "dodge" bullets (predict their path and not be where the enemy is shooting), and DODGE_CHANCE increases your effective dodge.

Also swap out UNCANNY_DODGE for HARDTOHIT.

Describe alternatives you've considered

Testing

What are you trying to tell me? That I can dodge bullets?

image

Still good to wear armor, though. You won't always get that lucky.

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding [Markdown] Markdown issues and PRs Mods: Mind Over Matter astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 12, 2024
@Maleclypse Maleclypse merged commit aa7dd5c into CleverRaven:master May 13, 2024
27 checks passed
@Standing-Storm Standing-Storm deleted the combat-sense branch May 13, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants