[MoM] Rework Combat Sense with modern enchants #73727
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[MoM] Rework Combat Sense with modern enchants"
Purpose of change
When I originally made the Combat Sense effect, BONUS_DODGE and BONUS_BLOCK were the only defense-increasing enchantments. That's not true anymore.
Describe the solution
Change BONUS_DODGE and BONUS_BLOCK to EVASION and DODGE_CHANCE. EVASION provides a flat chance to dodge any attack, replicating the extra defenses from the old version and also allowing you to "dodge" bullets (predict their path and not be where the enemy is shooting), and DODGE_CHANCE increases your effective dodge.
Also swap out UNCANNY_DODGE for HARDTOHIT.
Describe alternatives you've considered
Testing
Still good to wear armor, though. You won't always get that lucky.
Additional context