Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Add more enchants to effect scaling #73772

Merged
merged 5 commits into from
Jun 2, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented May 14, 2024

Summary

Mods "[Magiclysm] Add more enchants to effect scaling"

Purpose of change

Saw some more Magiclysm effects that could benefit from scaling.

Describe the solution

Edit the following spells:

  • Windrunning: Change scaling to enchant. It's as powerful as before at level 5/6, less powerful when lower and more powerful when higher.
  • Bless: Changed the flat bonus into a scaling one. At level 8 it's as powerful as before, and at level 16 it's more powerful.

Describe alternatives you've considered

Testing

Effects scale properly.

Additional context

I was going to change Root Strike and Ethereal Grasp, but I realized that the way to do scaling effects would prohibit targeting the ground with them, so I removed it.

@Standing-Storm Standing-Storm marked this pull request as draft May 14, 2024 14:33
@github-actions github-actions bot added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod labels May 14, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label May 14, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review May 31, 2024 14:32
@github-actions github-actions bot requested a review from KorGgenT May 31, 2024 14:32
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 31, 2024
@Maleclypse Maleclypse merged commit aff61cc into CleverRaven:master Jun 2, 2024
23 of 24 checks passed
@Standing-Storm Standing-Storm deleted the enchant-edits branch June 2, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants