Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added chimney/vent pipe above fireplace/wood stove on base shelter 1 #74211

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Added chimney/vent pipe above fireplace/wood stove on base shelter 1 #74211

merged 1 commit into from
Jun 1, 2024

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Provide roof outlets for shelter 1 base cooking facility (virtual) smoke.

Describe the solution

Add the corresponding directives to the JSON.

Describe alternatives you've considered

Testing

  • Loaded suitable save.
  • Debug spawned shelter 1.
  • Walked over to it, created a shelter 1 base camp, and built the fireplace.
  • Checked the results.
  • Repeated the above steps but f
    Screenshot (419)
    or the wood stove.
    Screenshot (420)
    Screenshot (421)
    Screenshot (422)

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 31, 2024
@dseguin dseguin merged commit 8d21dd0 into CleverRaven:master Jun 1, 2024
25 of 26 checks passed
@PatrikLundell PatrikLundell deleted the shelter1 branch June 1, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatrikLundell @dseguin