-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut down on gun_variant_validator blacklist #74248
Cut down on gun_variant_validator blacklist #74248
Conversation
Make name check case insensitive (so Rifle and rifle both work) Also, don't treat linkages as magazines, because they aren't Cull the blacklist based on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-requesting reviews from non-collaborators: @jbytheway
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
Add some variants to a few guns so that they pass the checks. Yes, I know BAR rifle will annoy some people. No, I don't care.
5b2ffea
to
76fff4b
Compare
Looks good to me! |
Summary
None
Purpose of change
Work towards the removal of the blacklists in
gun_variant_validator.py
so standards are enforced throughout the game.Describe the solution
Rename some guns, make some gun/magazine/gunmod names variants.
Also, some slight modifications to the script to fix some more false positives.
Describe alternatives you've considered
Different names?
Testing
tools/json_tools/gun_variant_validator.py -cin -v data/json
Additional context
Would appreciate review from people who know guns (@Holli-Git)
I would recommend reviewing by commit.