Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cooking_components group to snow cone recipe #74465

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

TheMurderUnicorn
Copy link
Contributor

Summary

Balance "Add cooking_components group to snow cone recipe"

Purpose of change

Snow cone recipe listed all components individually, but in my alcoholic snow cone PR it was pointed out that they should use the cooking_components groups of soda_pop and sweet_juice.

Describe the solution

Basically, instead of listing all those components individually, it now lists the group that contains those items.

Describe alternatives you've considered

None

Testing

Not really one that needs testing beyond making sure it linted/loaded correctly.

Additional context

These groups probably need expanding, the diet sodas at least do not appear in that group, I may do that at some point.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 11, 2024
@Maddremor
Copy link
Contributor

Looks good! If you want to continue working with requirements you could create a new list for teas (although I would make a distinction between nice tea and wilderness herbal brews).

@Maleclypse Maleclypse merged commit 7280af2 into CleverRaven:master Jun 12, 2024
26 checks passed
@TheMurderUnicorn TheMurderUnicorn deleted the SnowConeGroups branch July 4, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants