Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a zombie-flavored breather and cut spawns of them in meat lab #74663

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

kevingranade
Copy link
Member

Summary

None

Purpose of change

Fixes #71349
As reported in the above issue, meat labs were suffering from pretty bad slowdown due in part to breather aggression and in part due to there just being way too many breathers.

Describe the solution

Made a clone of breathers and breather hubs that are exactly the same but on team zombie.
Except they also have a smaller radius, they spawn within 3 tiles of the hub instead of 4.
I also cut the base spawn rate of breather hubs in meat labs a lot, to 1/10 the previous number.
In aggregate that means there are about 1/20th as many breathers per area in the labs, and on top of that there are significantly fewer inter-faction checks happening because the vast majority of meat lab occupants are amalgamations, which are in the zombie faction.

Describe alternatives you've considered

There's a potential tradeoff of breather spawn radius vs number of breather hubs that spawn. This just gets the total numbers reigned in to a decent number.
I do think the faction shift is necessary, even with a hundred or so breathers that's still a lot of aggression checks getting triggered for no reason.

Testing

Found a meat lab with teleporting around, waited a few minutes to let the breather population stabilize, then ran the game under perf to capture a profile.
Checked with debug that the things are actually spawning.
Killed a hub to verify the on-death effect is kicking in.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) labels Jun 19, 2024
@github-actions github-actions bot added Monsters Monsters both friendly and unfriendly. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 19, 2024
@Maleclypse Maleclypse merged commit cc3131f into master Jun 19, 2024
22 of 27 checks passed
@Maleclypse Maleclypse deleted the breather-fix branch June 19, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix/obsolete until fixing meat overgrown labs because of fps killer
2 participants