-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Magiclysm] Add a Translocator Gate to the Forge of Wonders. Also add consumable Forge warp scrolls. #74738
Merged
Maleclypse
merged 13 commits into
CleverRaven:master
from
QuillInkwell:magiclysm_forge_of_wonders_gate
Jun 25, 2024
Merged
[Magiclysm] Add a Translocator Gate to the Forge of Wonders. Also add consumable Forge warp scrolls. #74738
Maleclypse
merged 13 commits into
CleverRaven:master
from
QuillInkwell:magiclysm_forge_of_wonders_gate
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om spell file to EOC file. Rephrase warp scroll item descriptions.
…layer can both see and speak before starting EOC.
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Spawn
Creatures, items, vehicles, locations appearing on map
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mechanics: Enchantments / Spells
Enchantments and spells
EOC: Effects On Condition
Anything concerning Effects On Condition
<Bugfix>
This is a fix for a bug (or closes open issue)
labels
Jun 23, 2024
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
Jun 23, 2024
github-actions
bot
removed
the
json-styled
JSON lint passed, label assigned by github actions
label
Jun 23, 2024
…QuillInkwell/Cataclysm-DDA into magiclysm_forge_of_wonders_gate
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Jun 23, 2024
Maleclypse
reviewed
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
<Bugfix>
This is a fix for a bug (or closes open issue)
EOC: Effects On Condition
Anything concerning Effects On Condition
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mechanics: Enchantments / Spells
Enchantments and spells
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mods
Issues related to mods or modding
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[Magicylsm] Add Translocator gate to the Forge of Wonders and consumable Forge warp scrolls."
Purpose of change
Resolves #73598. With the Forge becoming globally unique access to it is a fair bit harder. This aims to remedy that somewhat with some theme fitting solutions.
Describe the solution
Add a Translocator Gate to the front of the Forge for players who have access to Translocate self.
Also add a new consumable item that allows for one round-trip per purchase. Forge Warp Scrolls. They should only be sold or spawned within the Forge itself. Once used you will teleported to the Forge Translocator gate. Your position before teleportation will be saved the scroll will transform into a return scroll. The return scrolls always take you to last positioned saved by the Forge Warp scroll. Currently there is restriction on how long you wait to use the return scroll.
Each Forge Warp scroll costs $300 and they are sold by Velzain. They should be pretty consistently available for purchase.
Each casting of the spell takes 5 minutes to complete. You need to be able to see, able to read, and able to speak to use the item. (Can see the incantation, can read what it says, can recite it aloud)
Describe alternatives you've considered
The idea of a rechargeable artifact that performed the function of the warp scroll but reusable was tossed around at one point. I've not added the item myself. But most of the infrastructure should be in place to easily create such an item, if it's desired in the future.
While adding the requirements of sight, reading, and speaking to the item. I considered leaving them out. Currently the item is a scroll you read aloud to cast the spell. But if reflavored into another kind of magic item without different activation criteria, these requirements could be relaxed. However, for spell casting characters everything that is actually required seems reasonable. Sure you could pass on the sight and reading requirements and say your character "Memorized the 5 minutes of incantation" but I can't be bothered to add that as a mechanic. At least when the EOC is already so complex.
There are no restrictions on teleporting. That is to say, the return scrolls never decay or go away. You are also no forbidden from leaving the forge after teleporting there. So you could in theory:
A) Base near the forge and use the scrolls as a free Magus Mark and Recall. Go out exploring, use the warp scroll to go to the forge than walk to your base. Unload and stock up. Than use the return scroll to go back out.
B) Warp to the forge from your base. Leave and explore the area around it. Use the return scroll to get back to your base.
I couldn't decide it was worth placing restrictions to prevent this. Or leave it in place as a reward for clever use of the resources presented to you. It at least is not as powerful as full access to translocation which in itself isn't too hard.
Testing
Created a new world, Travel to the Forge to set the location, Travel away, Warp to forge, Warp Back (Basic Functionality works)
Exited world after Forge loc set, Re-loaded world, Warp to forge, warp back (Forge location is not lost on exiting world)
Warp to Forge, Exit world, Re-load world, Warp back (Return point is not lost on exiting world)
Warp to forge, exit world, create character, warp to forge, exit world, load first character, warp back, (1st character returns to their own return point)
Warp to forge without visiting first. (Shouldn't be possible but just in case the game will fallback to doing a large range search for the forge.)
Verified time to cast is 5 minutes
Verified if player cancels item is not consumed.
Verified if player cannot see, cannot read, or cannot speak the spell cannot be cast.
Additional context