Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M110A1 Length Fix #75028

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

GusMorphism
Copy link
Contributor

@GusMorphism GusMorphism commented Jul 15, 2024

Summary

None

Purpose of change

Update the length of the M110A1 marksman's rifle to reflect the true length of the gun.

As seen here, the length of the gun with an attached suppressor is 40.12 inches, which comes out to 1019 mm.

Describe the solution

In gun/308.json , edit the length to 831 mm, then adjust the volume by the same percent change to compensate for the decrease in length resulting in 3266 ml rounded.

...
"volume": "3266 ml",
"longest_side": "831 mm",
...

Describe alternatives you've considered

  • Leave as is.

  • Don't change the volume. (Could not find good source on gun volume calculation methodology, re-defining that is way out of scope of this change, so I went for what made sense to me based on the current change)

Testing

  1. Changed values in gun/223.json
  2. Loaded in to game, acquired gun, un-installed all gunmods and mag
  3. Pulled up suppressor gunmod install screen
  4. Verified values and took screenshot

Additional context

m110a1 proof

for additional context see #75001

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON new contributor astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 15, 2024
@GusMorphism GusMorphism marked this pull request as ready for review July 15, 2024 05:46
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 15, 2024
@kevingranade kevingranade merged commit 006eac9 into CleverRaven:master Jul 19, 2024
39 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants