Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Update the length of the M110A1 marksman's rifle to reflect the true length of the gun.
As seen here, the length of the gun with an attached suppressor is 40.12 inches, which comes out to 1019 mm.
Describe the solution
In gun/308.json , edit the length to 831 mm, then adjust the volume by the same percent change to compensate for the decrease in length resulting in 3266 ml rounded.
...
"volume": "3266 ml",
"longest_side": "831 mm",
...
Describe alternatives you've considered
Leave as is.
Don't change the volume. (Could not find good source on gun volume calculation methodology, re-defining that is way out of scope of this change, so I went for what made sense to me based on the current change)
Testing
Additional context
for additional context see #75001