Prune some unneeded magiclysm items from the to-hit blacklist #75131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed the sewing kit becuase it's migrated in magiclysm but not mainline.
github-actions
bot
added
[JSON]
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
When I merged #74597 I noticed the blacklist check was failing on magiclysm, but it was missed because it wasn't in basic build.
Instead of kicking back that HUGE PR for re-validation I merged it and made this PR to clean up afterwards.
Describe the solution
Remove the magiclysm items from the blacklist that are not using the legacy property.
Remove the to-hit entry from the sewing kit in vanilla and remove it from the blacklist as well, Magiclysm was overriding it and not using legacy to-hit, vanilla was still using legacy to-hit, it's impossible to make both pass in this situation.
Testing
Reran the tests locally.