0.H backport appliance shutoff fix #75133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Bugfix>
…pt to appease the Clang 10 gods.
… to a bug in custom clang-tidy rule `cata-unsequenced-calls`.
github-actions
bot
added
the
astyled
-to avoid breaking other find_vehicle() calls
kevingranade
force-pushed
the
0.H-backport-appliance-shutoff-fix
branch
from
75cf66d
to
8a75d49
Compare
|
I tested this, looks good to me. I had a minimal repro save prepared (Wyandotte-trimmed.tar.gz) because of my abortive attempt at backporting this fix, with a lamp connected to a battery powered by bunch of asrgs 30 tiles away so that the lamp and battery straddle opposite edges of an OMT:
My test procedure was running off to the left for 4 OMTs and then running back right to see if the lamp is still lit. On current 0.H RC this disconnected the lamp maybe once every 3 tries. I built this PR branch and did the procedure 20 times, the lamp didn't disconnect once. |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "fixes appliances turning off randomly"
Purpose of change
Backport of fix to #69089 from #74964
Also backported #70404 for new coordinate type.
Describe the solution
See #74964
Testing
I don't have a reliable reproduction case for this, so I'm going on faith that it backports correctly.