Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more sophisticated logic and details in the sunset/sunrise morale #75404

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

NetSysFire
Copy link
Member

Summary

Content "More detailed sunset/sunrise morale based on actual weather and traits"

Purpose of change

Saw this new thing, immediately had the desire to flesh it out. Here we go.

Describe the solution

  • Takes weather into account. Is it sunny or clear?
    • Sunny/clear
      • Check if spiritual:
        • Character has a high chance (50%) of getting an increased morale (15 vs the normal 10) from the sunrise/sunset.
      • Otherwise high chance (80%) for a normal buff. 20% chance to see an exceptionally beautiful sunrise/sunset and get 15 vs the normal 10 of morale.
    • Everything else
      • Character gets only 5 morale which also decays much faster.

Describe alternatives you've considered

Also considering portal storms and making these give debuffs instead, the likes of "You look up an expect a sunset, but instead you see a twisted, eerie celestial body.". I already nested enough ifs for today. Plus we already have sun-related stuff in the portal eocs anyways.

Testing

image

While I tested this and am reasonably confident this will not cause errors, be extra vigilant when reviewing as this is my most complex EOC yet.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON EOC: Effects On Condition Anything concerning Effects On Condition astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 2, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 2, 2024
@dseguin dseguin merged commit 74dd8c2 into CleverRaven:master Aug 5, 2024
19 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants