Description fix for Bren 5.56x45mm carbine #75435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing text for the 5.56 version was copy-pasted from the 7.62mm carbine description text, and therefore referenced the wrong ammo type. Text was updated copying language from item "rdb_223".
github-actions
bot
added
[JSON]
RenechCDDA
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
I noticed in my last run that the description text for a gun (the Bren 5.56x45mm carbine) referenced the wrong ammo type, and discovered that the text was simply not updated after being copy-pasted from a different one (the "Bren 7.62mm carbine").
Describe the solution
I updated the text to refer to the correct ammo type, copying some existing appropriate text from another item (the "5.56x45mm bullpup rifle").
Describe alternatives you've considered
I considered adjusting the Bren variants to have newly separate names (both 5.56 and 7.62 versions have the shared variant of "CZ Bren 2 carbine"), but figured a minimal edit was appropriate.
Testing
Built from source, spawned all versions of Bren guns, and compared to behavior in a recent experimental build.
Additional context
Second attempt at this PR - apologies for any confusion!