Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix characters at the wrong level #75459

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Fix #75424, fix #75428, i.e. map rotation moving characters to map's "official" (abs_pos) Z level rather than retaining them at their current level.
This might also deal with #75244, but since I was unable to repeat that when following the bug report instructions I can't verify that.

Describe the solution

Use the correct Z level reference when rotating maps, i.e. retain them at their current level.

Describe alternatives you've considered

Testing

Repeating the error situations for the two fixed reports and verifying that the characters showed up at the correct Z level (Van whatever at the ground level, Luliya at her usual spot at level 2, and Rubik at his trading station at level 1).

Additional context

This being caused by rotation made it hard to track down, as reproduction attempts happened to be performed on unrotated maps...

@github-actions github-actions bot added Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 4, 2024
@Maleclypse Maleclypse merged commit 6ee8e16 into CleverRaven:master Aug 5, 2024
22 of 28 checks passed
@PatrikLundell PatrikLundell deleted the rubik branch August 5, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
2 participants