Genericize vehicle handling for characters (no special avatar stuff) #75467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Vehicles
RenechCDDA
force-pushed
the
npc_driving_infra
branch
2 times, most recently
from
5148114
to
7f740b4
Compare
github-actions
bot
added
Map / Mapgen
RenechCDDA
force-pushed
the
npc_driving_infra
branch
from
7f740b4
to
288bae2
Compare
RenechCDDA
force-pushed
the
npc_driving_infra
branch
from
288bae2
to
8cd1719
Compare
|
Wow that's a lot of angry vehicle tests. |
RenechCDDA
force-pushed
the
npc_driving_infra
branch
from
db1eb8a
to
77e0dd9
Compare
|
Just needed an override for the tests. Though all those test failures did make me reconsider some of the changes, I went for a more conservative approach with my code changes. Now there really, absolutely should be no functional changes no matter how technical. (Hopefully I don't have to force push this branch again to make it true) |
github-actions
bot
added
the
BasicBuildPassed
|
Apparently, remote control via drive-by-wire was broken by this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Describe the solution
Get us closer to the future. Prep the groundwork by getting rid of a bunch of assumptions that the player is the only character that can drive.
This does not enable NPCs to drive.
This is just a ton of tedious work that needs to be done before NPCs can drive, and I might as well get it out of the way.
Describe alternatives you've considered
player_in_controland a few other functions could use a renaming, but that was more churn than I wanted to deal with right nowTesting
Did some driving around with various kinds of vehicles. Jumped into them, jumped out of them, turned them on and off and on and off. Found a bug where the player couldn't start driving anything, squashed that.
Did some autodriving too, just to be sure. No issues, plays like I expect it to. Let's see how the tests do.
Additional context
There should be no functional changes.