Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TropiCata] Flying bird audit #75769

Merged
merged 10 commits into from
Aug 18, 2024
Merged

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Aug 17, 2024

Summary

None

Purpose of change

Starting to sanify TropiCata monsters

Describe the solution

Obsoleted

  • Cockatoo and Budgerigar - technically present in Brazil, but as sparsely observed pet escapees, not worth simulating
  • Flamingo - technically one species of flamingo does breed in Brazil, but it's not particularly common and reserved to one region. Other species sparsely visit the country

Existing audits - Honestly lots of shit. The most notable changes that resulted are:

  • Toucans can no longer be tamed
  • Parrots/Parakeets and Macaws can now only be tamed when young, like vanilla corvids
  • Size audits across the board - this made parrot/parakeet smaller, but toucans and macaws bigger
  • Inclusion of weakpoints and proficiencies
  • The affected birds now should dissect into bird samples
  • Reworked reproduction, so the birds actually take longer to lay eggs and grow to adulthood
  • Color changes for parrots/parakeets and macaws
  • Eggs of the birds affected in this PR can now be used for cooking and are smaller

New stuff to add:

  • Rufous Hornero
  • Saffron Finch
  • Great Kiskadee

I also cleaned up the egg mongroups while I was here because they were a hot mess

Describe alternatives you've considered

I also was hoping to add a Tamable Wildlife integration that would allow the taming of toucan chicks as well as adult parrots/parakeets and macaws, but I was told this isn't doable

I intend to follow up and audit the other birds after I do some more bird audits in vanilla.

It's also worth pointing out that feral quail aren't common in Brazil at all, but there are native species of quail so I'm leaving the monster in - I'll change the description when I audit it in the future

Testing

Additional context

All information obtained either from wikipedia or animaldiversity.org

The reproduction timer is the sum of egg hatch time and the time it takes for the young to fledge

Descriptions for the 3 new species authored by MammaJamma on the development discord

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Items: Food / Vitamins Comestibles and drinks Spawn Creatures, items, vehicles, locations appearing on map Monsters Monsters both friendly and unfriendly. Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 17, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • great kiskadee
  • great kiskadee egg
  • great kiskadee eggs
  • great kiskadees
  • rufous hornero
  • rufous hornero egg
  • rufous hornero eggs
  • rufous horneros
  • toco toucan
  • toco toucan egg
  • toco toucan eggs
  • toco toucans

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Karol1223 Karol1223 marked this pull request as ready for review August 17, 2024 11:29
@Karol1223 Karol1223 closed this Aug 17, 2024
@Karol1223 Karol1223 reopened this Aug 17, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 18, 2024
@Maleclypse Maleclypse merged commit 55090ed into CleverRaven:master Aug 18, 2024
48 of 63 checks passed
@Karol1223 Karol1223 deleted the tropicata-birds branch August 18, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants