Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #75364 #75822

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Backport #75364 #75822

merged 1 commit into from
Aug 19, 2024

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Backport #75364

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 19, 2024
@RenechCDDA
Copy link
Member

I don't think this needs backporting.

@GuardianDll
Copy link
Member Author

i'd like to have it for out of repo modders

@RenechCDDA
Copy link
Member

It's not fixing a bug. Better modder support is cool and all, but not something that we've previously considered appropriate for backporting.

@kevingranade
Copy link
Member

It's not at all risky, which is the main thing I'm worried about.
If we get a flood of tiny QoL backport requests that would be different.

@kevingranade kevingranade merged commit d204abf into 0.H-branch Aug 19, 2024
22 checks passed
@kevingranade kevingranade deleted the backport_debugmsg branch August 19, 2024 15:49
@RenechCDDA
Copy link
Member

OK, sounds reasonable. 👍

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants