Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format uilist menu entries with a table #75845

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

db48x
Copy link
Contributor

@db48x db48x commented Aug 20, 2024

Summary

Interface "format uilist menu entries with a table"

Purpose of change

This gets us better horizontal alignment of the menu entries if we ever move to a variable–width font. It also allows us to include the second label as its own column, which is currently only used by the butchery menu.

Testing

Butcher a corpse and check that the second column lists the duration of each possible butchery task.

Additional context

Fixes #75813 and #75680

Screenshot from 2024-08-20 07-29-33

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions labels Aug 20, 2024
This gets us better horizontal alignment of the menu entries if we
ever move to a variable–width font. It also allows us to include the
second label as its own column, which is currently only used by the
butchery menu.

Fixes CleverRaven#75813 and CleverRaven#75680
@db48x db48x force-pushed the implement-uilist-second-column branch from 8a801ad to 20011ca Compare August 20, 2024 14:49
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Aug 20, 2024
@Maleclypse Maleclypse merged commit cdd78ab into CleverRaven:master Aug 21, 2024
26 checks passed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the new ImGui–based uilist implementation doesn’t support a second column
2 participants