Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heat immune cleanup #76218

Merged
merged 19 commits into from
Sep 7, 2024
Merged

Heat immune cleanup #76218

merged 19 commits into from
Sep 7, 2024

Conversation

Naadn
Copy link
Contributor

@Naadn Naadn commented Sep 5, 2024

Summary

None

Purpose of change

Now HEAT_IMMUNE really make you immune to fire and other high temperature stuff, a lot patches in mods can be removed so maintenance can be simpler

Describe the solution

Remove some redundant code in json. Still keep some ARMOR_HEAT so clothe won't burned.

Describe alternatives you've considered

Don't

Testing

Character sleep in lava and think it can be warmer.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Mind Over Matter labels Sep 5, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Sep 5, 2024
@emixa-d
Copy link

emixa-d commented Sep 5, 2024

There is also ARMOR_HEAT in salamander_mutations.json.

@github-actions github-actions bot added Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mods: Xedra Evolved Anything to do with Xedra Evolved labels Sep 5, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Sep 6, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 6, 2024
@Maleclypse Maleclypse merged commit fb42a7a into CleverRaven:master Sep 7, 2024
24 checks passed
@Naadn Naadn deleted the fire-cleanup branch September 10, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Mind Over Matter Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants