-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heat immune cleanup #76218
Merged
Merged
Heat immune cleanup #76218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mods: Mind Over Matter
labels
Sep 5, 2024
github-actions
bot
added
the
astyled
astyled PR, label is assigned by github actions
label
Sep 5, 2024
There is also |
github-actions
bot
added
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Mods: Xedra Evolved
Anything to do with Xedra Evolved
labels
Sep 5, 2024
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Sep 6, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Sep 6, 2024
akrieger
reviewed
Sep 6, 2024
Maleclypse
reviewed
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mods: Mind Over Matter
Mods: Xedra Evolved
Anything to do with Xedra Evolved
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Now
HEAT_IMMUNE
really make you immune to fire and other high temperature stuff, a lot patches in mods can be removed so maintenance can be simplerDescribe the solution
Remove some redundant code in json. Still keep some
ARMOR_HEAT
so clothe won't burned.Describe alternatives you've considered
Don't
Testing
Character sleep in lava and think it can be warmer.
Additional context