allow scrolling of spell info again #76265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "Fix scrolling spell info in spell casting menu"
Purpose of change
spell info scrolling was broken when the spell menu migrated to uilist.
Before this PR the only way to scroll the spell info of spells with long descriptions (like the first circle spells)
was by focusing and scrolling the spell info window with the mouse (which is not obvious as a possibility at all).
Describe the solution
I extracted the already existing scrolling logic in item menu to our helper class
cataimgui
, and used it both in item menuand in the casting menu. It uses the existing previous keybinds for scrolling that were defined but non-functioning.
Describe alternatives you've considered
I tried to figure out how to make the scrollbar visible for spell info, but got stumped and decided it's better to leave it for another PR.
Testing
magicalysm
mod<
and>
) to scroll the spell info to show the spell componentsI also tested rebinding the keys in the
?
menu, and tested that the item menu scrolling still functions as before.Additional context