-
Notifications
You must be signed in to change notification settings - Fork 400
Improve build-scripts #3168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve build-scripts #3168
Conversation
|
Okay, i'm not crazy: https://stackoverflow.com/questions/68636358/file-not-found-in-alpine-container-despite-existing https://stackoverflow.com/questions/66963068/docker-alpine-executable-binary-not-found-even-if-in-path Seems to be an underlying reason why no matter what I try I cannot run the clickhouse binary in the docs build (we just never picked this up because there was zero error handling in the original autogenerate-settings script, so it just always printed "Successfully generated settings" LOL |
|
@gingerwizard ready for review on this. I think I know why we have "new-build". here we pass arg "/output_path/build": This is passed as an argument to Line 10 in 2060b8d
If I try change When we remove htmltest we'll be able to put everything in |
|
Need to fix broken links in settings first: ClickHouse/ClickHouse#75524 and URLs: ClickHouse/ClickHouse#75549 and broken hashes: ClickHouse/ClickHouse#75637 |
Summary
prep-from-local, 'prep-from-master' andcopyClickhouseRepoDocs.shwith a single scriptscripts/copy-clickhouse-repo-docs.shwhich performs oldprep-from-masterby default or can performprep-from-localif you provide it arg-l.copy-clickhouse-repo-docs.shadditionally copies files needed for any kind of autogeneration (changelog and settings generation) tosettings/tmp. New files can be added to package.json "autogen_needed_files" to extend.copy-clickhouse-repo-docs.shuses rsync, falls back to cp if it cannot find rsyncTo do:
Checklist