Skip to content

show type and default for autogenerated server settings #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025
Merged

show type and default for autogenerated server settings #3562

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c32a82
show type and default
Blargian Mar 26, 2025
de9a4e6
backtick default and type
Blargian Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions scripts/settings/autogenerate-settings.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ settings_from_cpp AS
),
main_content AS
(
SELECT format('## {} {}\\n{}\\n\\nType: {}\\n\\nDefault value: {}\\n\\n{}\\n\\n',
SELECT format('## {} {}\\n{}\\n\\nType: \`{}\`\\n\\nDefault: \`{}\`\\n\\n{}\\n\\n',
name, '{#'||name||'}', multiIf(tier == 'Experimental', '<ExperimentalBadge/>', tier == 'Beta', '<BetaBadge/>', ''), type, default, trim(BOTH '\\n' FROM description))
FROM system.settings WHERE name IN settings_from_cpp
ORDER BY name
Expand Down Expand Up @@ -134,25 +134,38 @@ WITH
(
SELECT
name,
replaceRegexpAll(description, '(?m)^[ \t]+', '') AS description
replaceRegexpAll(description, '(?m)^[ \t]+', '') AS description,
type,
default
FROM system.server_settings
),
combined_server_settings AS
(
SELECT
name,
description
description,
type,
default
FROM server_settings_in_source
UNION ALL
SELECT
name,
doc AS description
doc AS description,
'' AS type,
'' AS default
FROM server_settings_outside_source
),
formatted_settings AS
(
SELECT
format('## {} {}\n\n{}\n\n', name, lcase('{#'||name||'}'), description) AS formatted_text
format(
'## {} {}\n\n{}{}{}\n\n',
name,
lcase('{#'||name||'}'),
if(type != '', concat('Type: \`', type, '\`\n\n'), ''),
if(default != '', concat('Default: \`', default, '\`\n\n'), ''),
description
) AS formatted_text
FROM combined_server_settings
ORDER BY name ASC
),
Expand Down