Skip to content

Bug fix: typing / while Ask AI widget is open triggers Docsearch pop-up (again) #4448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

Bug fix: typing / while Ask AI widget is open triggers Docsearch pop-up (again) #4448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions src/theme/SearchBar/utils/aiConflictHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@ import { SEARCH_SHORTCUTS, INPUT_FIELD_SELECTORS } from '../searchConstants';
*/
function isInputField(activeElement) {
if (!activeElement) return false;


// Check for Kapa AI input by placeholder text (most reliable)
if (activeElement.placeholder === "Ask me a question about ClickHouse...") {
return true;
}

return INPUT_FIELD_SELECTORS.some(selector => {
if (selector.startsWith('#') || selector.startsWith('[')) {
return activeElement.matches?.(selector) || activeElement.closest?.(selector);
Expand Down Expand Up @@ -48,13 +53,18 @@ function isSearchShortcut(event) {
export function handleSearchKeyboardConflict(event, isAskAIOpen) {
if (!isSearchShortcut(event)) return;

if (shouldPreventSearchAction(isAskAIOpen)) {
// Special case: allow "/" in input fields
if (event.key === SEARCH_SHORTCUTS.SLASH && !shouldPreventSearchAction(isAskAIOpen)) {
event.stopImmediatePropagation();
} else {
event.preventDefault();
event.stopImmediatePropagation();
}
// If Ask AI is not open, don't interfere with normal search behavior
if (!isAskAIOpen) return;

const activeElement = document.activeElement;

// If we're typing in an input field when AI is open, allow "/" but prevent search modal
if (event.key === SEARCH_SHORTCUTS.SLASH && isInputField(activeElement)) {
event.stopImmediatePropagation();
return;
}

// Otherwise, when AI is open and not in input field, prevent all search shortcuts
event.preventDefault();
event.stopImmediatePropagation();
}