More dbt small changes #4574
Open
More dbt small changes #4574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
koletzilla
force-pushed
the
dbt-clickhouse/documentation-updates
branch
from
9b9628d to
f974351
Compare
koletzilla
commented
Oct 14, 2025
Comment on lines
+148
to
+149
| | indexes | A list of [data skipping indexes](/optimize/skipping-indexes) to create. See [About data skipping indexes](#data-skipping-indexes) for details. | | | ||
| | sql_security | The ClickHouse user to use when executing the view's underlying query. [Accepted values](/sql-reference/statements/create/view#sql_security): `definer`, `invoker`. | | |
There was a problem hiding this comment.
@morsapaes sorry, I changed these lines with your suggestions in #4562 (review) and I didn't commit them 🤦
koletzilla
commented
Oct 14, 2025
Comment on lines
-134
to
+136
| ### General table configurations {#general-table-configurations} | ||
| ### General model configurations {#general-model-configurations} | ||
|
|
||
| The following table shows configurations shared by some of the available materializations. For in-depth information about general dbt model configurations, see the [dbt documentation](https://docs.getdbt.com/category/general-configs): |
There was a problem hiding this comment.
@morsapaes I have been doing some changes related to the reorganization of the settings per each materialization:
- It has not been easy to redistribute the settings for each materialization as most of them are used by several materializations. The only only two that I could move have been
unique_keyandsharding_key - I have changed the title and the explanation to make it clear that these configs are shared by most of the materializations and that this is related to the
model, not to atable. - Do you have any suggestion about possible structure improvements? I guess that at some point we can just move all configs to each of the materializations and just duplicate the setting explanation when needed. But thinking about it, I feel like it may complicate the reading/understanding of existing configurations.
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary