Skip to content

Conversation

@Am-phi
Copy link
Contributor

@Am-phi Am-phi commented Oct 16, 2024

Summary

The setting database in the InsertSettings wasn't used when doing insert as only the database in the config was considered. This PR aim to fix this issue

Closes: #1868

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2024

CLA assistant check
All committers have signed the CLA.

@chernser
Copy link
Contributor

@Am-phi many thanks for the fix!

@chernser
Copy link
Contributor

@Am-phi I've approved. Would you please resolve merge conflicts and I will merge it?

Thanks!

@chernser chernser merged commit 758b51d into ClickHouse:main Oct 21, 2024
55 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[client-v2] InsertSettings::SetDatabase not working

3 participants