Skip to content

Fix JDBC driver prints stack trace to stdout #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Fix JDBC driver prints stack trace to stdout #1880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8a3984
Fix(clickhouse-client): Log the exception instead of printing the sta…
Am-phi Oct 23, 2024
9585171
Tweak(): Add an error log when an error occurred during a ping for cl…
Am-phi Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
import com.clickhouse.data.ClickHouseValue;
import com.clickhouse.data.ClickHouseValues;
import com.clickhouse.data.ClickHouseWriter;
import com.clickhouse.logging.Logger;
import com.clickhouse.logging.LoggerFactory;

/**
* A unified interface defines Java client for ClickHouse. A client can only
Expand All @@ -56,6 +58,7 @@
* implementation properly in runtime.
*/
public interface ClickHouseClient extends AutoCloseable {
Logger LOG = LoggerFactory.getLogger(ClickHouseClient.class);

/**
* Returns a builder for creating a new client.
Expand Down Expand Up @@ -959,8 +962,8 @@ default boolean ping(ClickHouseNode server, int timeout) {
.get(timeout, TimeUnit.MILLISECONDS)) {
return resp != null;
} catch (Exception e) {
// ignore
e.printStackTrace();
LOG.debug("Failed to connect to the server", e);
return false;
}
}

Expand Down
1 change: 1 addition & 0 deletions client-v2/src/main/java/com/clickhouse/client/api/Client.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1035,6 +1035,7 @@ public boolean ping(long timeout) {
try (QueryResponse response = query("SELECT 1 FORMAT TabSeparated").get(timeout, TimeUnit.MILLISECONDS)) {
return true;
} catch (Exception e) {
LOG.debug("Failed to connect to the server", e);
return false;
}
} else {
Expand Down
Loading