Skip to content

Conversation

@vonnagy
Copy link

@vonnagy vonnagy commented Sep 2, 2021

Added back support for readUnsignedLeb128 in ClickHouseRowBinaryInputStream.

@lucky
Copy link

lucky commented Sep 2, 2021

This fixes #710

@vonnagy vonnagy changed the title 710 - Added back readUnsignedLeb128 in ClickHouseRowBinaryInputStream #710 - Added back readUnsignedLeb128 in ClickHouseRowBinaryInputStream Sep 2, 2021
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Benchmark                           (client)  (statement)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc       normal  thrpt   20   285.605 ±  26.517  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20   271.768 ±  28.925  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc       normal  thrpt   20  1880.773 ± 188.142  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20  1971.215 ± 205.085  ops/s

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Benchmark                           (client)  (statement)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc       normal  thrpt   20   264.627 ±  28.024  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20   261.372 ±  27.248  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc       normal  thrpt   20  1348.103 ± 138.889  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20  1384.503 ± 113.605  ops/s

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2021

CLA assistant check
All committers have signed the CLA.

@zhicwu zhicwu changed the base branch from master to develop October 5, 2021 23:25
@zhicwu zhicwu linked an issue Oct 10, 2021 that may be closed by this pull request
@zhicwu
Copy link
Contributor

zhicwu commented Oct 10, 2021

I was not able to update the PR so I merged the change in a separate PR #742.

@zhicwu zhicwu closed this Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add back readUnsignedLeb128 in ClickHouseRowBinaryInputStream

4 participants