Skip to content

feat: allow using TLS client certificates #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2025
Merged

feat: allow using TLS client certificates #413

merged 2 commits into from
Feb 6, 2025

Conversation

@bartoszwjn
Copy link
Contributor

@bartoszwjn bartoszwjn commented Feb 4, 2025 •
edited
Loading

Summary

Exposes the TLS client certificate settings from clickhouse-connect/clickhouse-driver as profile parameters.

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

@CLAassistant
Copy link

CLAassistant commented Feb 4, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@bartoszwjn bartoszwjn marked this pull request as ready for review February 4, 2025 22:10
@BentsiLeviav
Copy link
Collaborator

Thank you for this contribution!

@BentsiLeviav
Copy link
Collaborator

Could you please merge main into your branch? I removed a problematic update

@BentsiLeviav BentsiLeviav merged commit 57db2b2 into ClickHouse:main Feb 6, 2025
21 checks passed
@bartoszwjn bartoszwjn deleted the tls-client-cert-pr branch February 6, 2025 14:27
@mlazowik mlazowik mentioned this pull request Oct 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bartoszwjn @CLAassistant @BentsiLeviav