-
Notifications
You must be signed in to change notification settings - Fork 78
Align Spark 4.0 dependencies with Spark 4.0.1 release #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Update Jackson from 2.17.0 to 2.18.2 - Update SLF4J from 2.0.7 to 2.0.16 - Update Jakarta Annotations from 1.3.5 to 2.1.1 All 315 tests pass with these updated dependencies, including: - Arrow 18.1.0 compatibility (Arrow writer tests) - Jackson 2.18.2 compatibility (JSON reader/writer tests) - All data type mappings and cluster operations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🤙
💡 To request another review, post a new comment with "/windsurf-review".
- Add Spark 4.0 to requirements - Update compatible matrix: main branch now supports Spark 3.3, 3.4, 3.5, 4.0 - Add 0.8.1 version row for Spark 3.3, 3.4, 3.5 - Keep ClickHouse JDBC version as 0.6.3 for main and 0.8.1
cc27053 to
4f2ffb6
Compare
mzitnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure that we are testing with a real running version of Spark
| # javax annotations removed in jdk 11 | ||
| # fix build error with jakarta annotations | ||
| jakarta_annotation_api_version=1.3.5 | ||
| jakarta_annotation_api_version=2.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it used to address gRPC-generated code issues, and is useless now, let's remove this dependency directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #64
| spark_33_scala_213_version=2.13.8 | ||
| spark_34_scala_213_version=2.13.8 | ||
| spark_35_scala_213_version=2.13.8 | ||
| spark_40_scala_213_version=2.13.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scala 4.0 uses 2.13.16
you can find the full deps list at https://github.com/apache/spark/blob/v4.0.1/dev/deps/spark-deps-hadoop-3-hive-2.3
| spark_40_slf4j_version=2.0.16 | ||
|
|
||
| # Align with Apache Spark, and don't bundle them in release jar. | ||
| commons_lang3_version=3.12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.17.0, otherwise some enum, e.g., JAVA_24, which does not exist in older versions, may cause runtime linkage issues
| jakarta_annotation_api_version=2.1.1 | ||
|
|
||
| # Test only | ||
| kyuubi_version=1.9.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.10.2, a clean no-deps jar
Align Spark 4.0 dependencies with Spark 4.0.1 release
Updates gradle.properties to match dependency versions from Apache Spark 4.0.1:
2.17.0 → 2.18.22.0.7 → 2.0.161.3.5 → 2.1.1This closes #407 and addresses #405