Skip to content

V0.2.0 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 4, 2022
Merged

V0.2.0 #27

merged 9 commits into from
Nov 4, 2022

Conversation

@quwenjie
Copy link
Collaborator

@quwenjie quwenjie commented Nov 3, 2022 •
edited
Loading

Bump to rust version 0.2.0:

@quwenjie quwenjie requested a review from camelop November 3, 2022 20:51
@camelop
Copy link
Contributor

camelop commented Nov 4, 2022 •
edited
Loading

Change - Rust repo

@quwenjie quwenjie linked an issue Nov 4, 2022 that may be closed by this pull request
Better task selection in the example #26
Closed
camelop
camelop requested changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@camelop camelop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! Please see the detailed comment.
Also, we are upgrading the testing infrastructure soon and we can also discuss that in our next sync. Thanks for the great effort!

@camelop
Copy link
Contributor

camelop commented Nov 4, 2022

Also just come to my mind: we can probably do an intermediate version of refactoring - like you mentioned, break it into several files - after this PR.

@quwenjie quwenjie requested a review from camelop November 4, 2022 09:21
camelop
camelop requested changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@camelop camelop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only tiny issues!

camelop
camelop approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@camelop camelop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@quwenjie quwenjie merged commit 7c5a61c into main Nov 4, 2022
@quwenjie quwenjie deleted the v0.2.0 branch November 4, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camelop camelop camelop approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Better task selection in the example

3 participants

@quwenjie @camelop