Skip to content

Conversation

@stneng
Copy link
Member

@stneng stneng commented Feb 24, 2023

No description provided.

@stneng stneng requested a review from camelop February 24, 2023 13:53
Copy link

@camelop camelop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the part that handles curd looks great! and it's nice that you also added append.
But maybe in terms of format, shall we have another discussion?

@stneng stneng requested a review from camelop February 28, 2023 04:02
@stneng stneng changed the title Storage Macro: local file system Storage Macro: file system Feb 28, 2023
Copy link

@camelop camelop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@stneng stneng merged commit a7a3a94 into main Mar 1, 2023
@stneng stneng deleted the storage-macro-fs branch March 1, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants