Add/rework exceptions

[CoMPaTech]

Summary by CodeRabbit

• Bug Fixes
  • Enhanced error handling by introducing more specific error messages for authentication failures, connection setup problems, and general device connection issues.
• Chores
  • Updated the project version to 0.0.8.

[coderabbitai]

Walkthrough

The changes introduce a more granular exception hierarchy for connection and authentication errors in the airos module. Custom exceptions now distinguish between connection setup, authentication, and general connection errors. The project version is incremented from 0.0.7 to 0.0.8. No public API signatures were altered.

Changes

File(s)	Change Summary
airos/exceptions.py	Removed ConnectionFailedError; added ConnectionSetupError, ConnectionAuthenticationError, and DeviceConnectionError.
airos/airos8.py	Replaced generic connection exceptions with new specific exceptions for setup, authentication, and device connection errors.
pyproject.toml	Bumped project version from 0.0.7 to 0.0.8.

Poem

A hop and a skip, new errors abound,
With finer distinctions, bugs will be found.
From setup to login, each step has a name,
The code’s more precise, though the flow stays the same.
With version bumped up, we leap to new heights—
🐇✨ Onward, through all of our coding delights!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7098724 and 4af4607.

📒 Files selected for processing (2)

• airos/airos8.py (5 hunks)
• airos/exceptions.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• airos/airos8.py
• airos/exceptions.py

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch testing

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 306877d and 7098724.

📒 Files selected for processing (3)

• airos/airos8.py (5 hunks)
• airos/exceptions.py (1 hunks)
• pyproject.toml (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

airos/airos8.py (1)

airos/exceptions.py (4)

• ConnectionAuthenticationError (16-17)
• ConnectionError (8-9)
• ConnectionSetupError (12-13)
• DataMissingError (20-21)

🔇 Additional comments (10)

pyproject.toml (1)

7-7: LGTM! Appropriate version bump for the exception refactoring.

The patch version increment from 0.0.7 to 0.0.8 is appropriate for the internal exception hierarchy improvements without breaking changes to the public API.

airos/exceptions.py (1)

12-18: Excellent granular exception hierarchy.

The new ConnectionSetupError and ConnectionAuthenticationError exceptions provide much better error categorization than the previous generic approach. This will help users handle different failure modes more appropriately.

airos/airos8.py (8)

11-16: Clean import organization for new exception hierarchy.

The imports are well-organized and include all the necessary exceptions for the refactored error handling. The alphabetical ordering makes the imports easy to read.

---

101-101: Appropriate use of ConnectionSetupError for cookie validation.

Using ConnectionSetupError when cookies are missing after login is semantically correct - this represents a setup/preparation failure rather than missing data in general.

---

154-154: Consistent exception usage for empty cookie jar.

The ConnectionSetupError is appropriate here for when the cookie jar is empty after login POST, maintaining consistency with the other cookie-related setup failures.

---

162-162: Proper exception for missing required cookies.

Using ConnectionSetupError when neither AIROS_ nor ok cookies are found is correct - this indicates a setup failure during the authentication preparation phase.

---

178-178: Excellent use of ConnectionAuthenticationError for login failures.

The ConnectionAuthenticationError is the perfect exception for login failures with non-200 status codes, providing clear semantics about the authentication failure.

---

181-181: Appropriate exception chaining for client errors.

Using ConnectionError with from err properly chains the underlying aiohttp.ClientError while categorizing it as a connection issue. The exception chaining preserves the original error context.

---

187-187: Correct exception for disconnected state.

Raising ConnectionError when not connected and attempting to access status is semantically appropriate - it represents a connection state issue.

---

213-213: Consistent connection error handling.

The ConnectionError with proper exception chaining maintains consistency with the other connection-related error handling in the file.