Skip to content

Conversation

@Zrzyck
Copy link
Contributor

@Zrzyck Zrzyck commented Aug 14, 2025

This pull request adds two anonymized configuration outputs from LiteBeam 5AC devices operating in PTP bridge mode:

  • LiteBeam 5AC - AP mode
  • LiteBeam 5AC - Station mode

Data was collected via /status.cgi and anonymized according to the guidelines:

  • IP addresses replaced with 127.0.0.x while keeping last octet coherent
  • SSIDs replaced with placeholder names
  • Hostnames and MAC addresses redacted to valid but non-realistic values

Summary by CodeRabbit

  • Tests
    • Added comprehensive device-state fixtures for LiteBeam 5AC in AP‑PTP and STA‑PTP (30 MHz) covering full telemetry, wireless configs, per‑station metrics, interfaces, and system stats to improve test coverage.
  • Chores
    • Expanded fixture dataset for more realistic validation and QA scenarios.
  • Documentation
    • Provides concrete sample telemetry to clarify expected fields and structures.
  • Refactor
    • No functional or API changes; behavior unchanged.

@coderabbitai
Copy link

coderabbitai bot commented Aug 14, 2025

Walkthrough

Adds two new JSON fixture files under fixtures/userdata providing complete telemetry snapshots for LiteBeam 5AC devices in AP-PTP and STA-PTP modes at 30 MHz. The additions are data-only fixtures with detailed wireless, station, remote device, and interface metrics; no code or API changes.

Changes

Cohort / File(s) Summary of Changes
Userdata fixtures (LiteBeam 5AC 30 MHz)
fixtures/userdata/LiteBeam5AC_ap-ptp_30mhz.json, fixtures/userdata/LiteBeam5AC_sta-ptp_30mhz.json
Added two full device-state JSON snapshots (AP-PTP and STA-PTP) containing host metadata, chain names, genuine image reference, services/firewall flags, wireless configuration (mode, band, freq, chanbw, security, antennas, chain masks), per-station metrics (signal, rssi, noisefloor, chainrssi, tx/rx stats, throughput, AIRMAX/CINR/EVM data), remote device descriptors, interfaces counters/states, provmode/ntpclient placeholders, and unms status. No executable logic or exported signatures changed.

Sequence Diagram(s)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I nudge a JSON carrot in a field of bits,
Two beams at thirty hum soft network hits.
AP and STA, a tiny hop and spin,
Counters counted, signals snug within.
I twitch my whiskers — fixtures tucked in! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c6355ac and 7dcc3b3.

📒 Files selected for processing (1)
  • fixtures/userdata/LiteBeam5AC_sta-ptp_30mhz.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • fixtures/userdata/LiteBeam5AC_sta-ptp_30mhz.json
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (2)
fixtures/userdata/LiteBeam5AC_sta-ptp_30mhz.json (1)

499-500: Optional: Anonymize IPv6 link-local addresses (EUI-64 leaks MACs)

fe80::/64 link-local addresses embed the device MAC (EUI-64). Even with MACs anonymized, these IPv6s re-encode them. Consider substituting neutral values while keeping coherence across AP/STA.

Apply this diff:

-                    "ip6addr": [
-                        "fe80::6ad7:9aff:fe9a:8be"
-                    ],
+                    "ip6addr": [
+                        "fe80::21"
+                    ],

-                "ip6addr": [
-                    {
-                        "addr": "fe80::6ad7:9aff:fe98:fbff",
-                        "plen": 64
-                    }
-                ],
+                "ip6addr": [
+                    {
+                        "addr": "fe80::22",
+                        "plen": 64
+                    }
+                ],

If you prefer to retain more realism, we can instead generate consistent synthetic EUI-64 addresses derived from your redacted MACs.

Also applies to: 579-584

fixtures/userdata/LiteBeam5AC_ap-ptp_30mhz.json (1)

499-501: Optional: Also anonymize IPv6 link-local to avoid EUI-64 MAC leakage

Similar to the STA fixture, fe80:: addresses encode MACs. Recommend neutral replacements while maintaining AP/STA coherence (AP ⇄ STA mapping 21 ⇄ 22).

Apply this diff:

-                    "ip6addr": [
-                        "fe80::6ad7:9aff:fe98:fbf6"
-                    ],
+                    "ip6addr": [
+                        "fe80::22"
+                    ],

-                    {
-                        "addr": "fe80::6ad7:9aff:fe9a:8bb",
-                        "plen": 64
-                    }
+                    {
+                        "addr": "fe80::21",
+                        "plen": 64
+                    }

Also applies to: 581-584

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 40ea0e2 and c6355ac.

📒 Files selected for processing (2)
  • fixtures/userdata/LiteBeam5AC_ap-ptp_30mhz.json (1 hunks)
  • fixtures/userdata/LiteBeam5AC_sta-ptp_30mhz.json (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (2)
fixtures/userdata/LiteBeam5AC_ap-ptp_30mhz.json (1)
script/generate_ha_fixture.py (1)
  • generate_airos_fixtures (22-59)
fixtures/userdata/LiteBeam5AC_sta-ptp_30mhz.json (1)
script/generate_ha_fixture.py (1)
  • generate_airos_fixtures (22-59)
🔇 Additional comments (2)
fixtures/userdata/LiteBeam5AC_sta-ptp_30mhz.json (1)

1-595: Overall structure and content LGTM

Well-structured, comprehensive snapshot with fields consistent with existing userdata fixtures. Once the anonymization fixes are applied, this should flow through generate_ha_fixture.py without surprises.

fixtures/userdata/LiteBeam5AC_ap-ptp_30mhz.json (1)

1-596: LGTM: Solid, coherent AP-PTP fixture with correct anonymization choices

Data shape matches existing patterns; IPv4 anonymization to 127.0.0.x is consistent across fields; MAC/hostnames look plausibly redacted while remaining valid. Complements the STA fixture well.

@CoMPaTech
Copy link
Owner

Thank you very much for the PR and the kind words @Zrzyck - I've created a small PR that will also attempt to digest userdata that I'm merging ahead, but your first file parses correctly on 0.2.10 (and should on 0.2.8 that will be in Core 2025.8.2 via home-assistant/core#150504)

@sonarqubecloud
Copy link

@CoMPaTech CoMPaTech merged commit 7993f7a into CoMPaTech:main Aug 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants