-
Notifications
You must be signed in to change notification settings - Fork 1
add LiteBeam 5AC bridge config from /status.cgi #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds two new JSON fixture files under fixtures/userdata providing complete telemetry snapshots for LiteBeam 5AC devices in AP-PTP and STA-PTP modes at 30 MHz. The additions are data-only fixtures with detailed wireless, station, remote device, and interface metrics; no code or API changes. Changes
Sequence Diagram(s)Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Nitpick comments (2)
fixtures/userdata/LiteBeam5AC_sta-ptp_30mhz.json (1)
499-500: Optional: Anonymize IPv6 link-local addresses (EUI-64 leaks MACs)fe80::/64 link-local addresses embed the device MAC (EUI-64). Even with MACs anonymized, these IPv6s re-encode them. Consider substituting neutral values while keeping coherence across AP/STA.
Apply this diff:
- "ip6addr": [ - "fe80::6ad7:9aff:fe9a:8be" - ], + "ip6addr": [ + "fe80::21" + ], - "ip6addr": [ - { - "addr": "fe80::6ad7:9aff:fe98:fbff", - "plen": 64 - } - ], + "ip6addr": [ + { + "addr": "fe80::22", + "plen": 64 + } + ],If you prefer to retain more realism, we can instead generate consistent synthetic EUI-64 addresses derived from your redacted MACs.
Also applies to: 579-584
fixtures/userdata/LiteBeam5AC_ap-ptp_30mhz.json (1)
499-501: Optional: Also anonymize IPv6 link-local to avoid EUI-64 MAC leakageSimilar to the STA fixture, fe80:: addresses encode MACs. Recommend neutral replacements while maintaining AP/STA coherence (AP ⇄ STA mapping 21 ⇄ 22).
Apply this diff:
- "ip6addr": [ - "fe80::6ad7:9aff:fe98:fbf6" - ], + "ip6addr": [ + "fe80::22" + ], - { - "addr": "fe80::6ad7:9aff:fe9a:8bb", - "plen": 64 - } + { + "addr": "fe80::21", + "plen": 64 + }Also applies to: 581-584
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
fixtures/userdata/LiteBeam5AC_ap-ptp_30mhz.json(1 hunks)fixtures/userdata/LiteBeam5AC_sta-ptp_30mhz.json(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (2)
fixtures/userdata/LiteBeam5AC_ap-ptp_30mhz.json (1)
script/generate_ha_fixture.py (1)
generate_airos_fixtures(22-59)
fixtures/userdata/LiteBeam5AC_sta-ptp_30mhz.json (1)
script/generate_ha_fixture.py (1)
generate_airos_fixtures(22-59)
🔇 Additional comments (2)
fixtures/userdata/LiteBeam5AC_sta-ptp_30mhz.json (1)
1-595: Overall structure and content LGTMWell-structured, comprehensive snapshot with fields consistent with existing userdata fixtures. Once the anonymization fixes are applied, this should flow through generate_ha_fixture.py without surprises.
fixtures/userdata/LiteBeam5AC_ap-ptp_30mhz.json (1)
1-596: LGTM: Solid, coherent AP-PTP fixture with correct anonymization choicesData shape matches existing patterns; IPv4 anonymization to 127.0.0.x is consistent across fields; MAC/hostnames look plausibly redacted while remaining valid. Complements the STA fixture well.
|
Thank you very much for the PR and the kind words @Zrzyck - I've created a small PR that will also attempt to digest userdata that I'm merging ahead, but your first file parses correctly on 0.2.10 (and should on 0.2.8 that will be in Core 2025.8.2 via home-assistant/core#150504) |
|



This pull request adds two anonymized configuration outputs from LiteBeam 5AC devices operating in PTP bridge mode:
Data was collected via /status.cgi and anonymized according to the guidelines:
Summary by CodeRabbit