Skip to content

Conversation

@not-matthias
Copy link
Member

@not-matthias not-matthias commented Oct 20, 2025

Fixes #26

Changes in this PR:

  • Only enable -Wall and -Werror in CI
  • Bump instrument-hooks and sync CLFAGS

@not-matthias not-matthias force-pushed the cod-1520-compiler-warning-on-v130 branch 2 times, most recently from d3b689e to 36c6db4 Compare October 20, 2025 08:55
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2025

CodSpeed Performance Report

Merging #27 will degrade performances by 32.11%

Comparing cod-1520-compiler-warning-on-v130 (4a4951f) with main (f615ab6)

Summary

⚡ 5 improvements
❌ 1 regression
✅ 146 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
Instrumentation BM_Capture[int_string_test] 90.6 ns 61.4 ns +47.51%
Instrumentation BM_Capture[int_test] 90.6 ns 61.4 ns +47.51%
Instrumentation BM_Template1[int] 90.8 ns 61.7 ns +47.3%
Instrumentation BM_Template1_Capture[int_string_test] 90.6 ns 61.4 ns +47.51%
Instrumentation BM_Template1_Capture[two_type_test, int, double] 90.6 ns 61.4 ns +47.51%
Instrumentation BM_Template2[int, double] 61.7 ns 90.8 ns -32.11%

@not-matthias not-matthias force-pushed the cod-1520-compiler-warning-on-v130 branch from 36c6db4 to f429757 Compare October 20, 2025 09:08
@not-matthias not-matthias requested a review from Copilot October 20, 2025 09:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes compiler warnings on v130 by making strict warning flags (-Wall and -Werror) conditional and only enabling them during CI builds, while maintaining consistency across build systems.

  • Introduces conditional strict warning flags that are only enabled in CI environments
  • Updates CMake and Bazel build configurations to use synchronized compiler flag lists
  • Bumps instrument-hooks submodule to a newer version

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
core/instrument-hooks Updates submodule to newer commit
core/CMakeLists.txt Adds conditional strict warnings option and synchronized compiler flags
core/BUILD Implements Bazel equivalent of strict warnings with flag synchronization
.github/workflows/ci.yml Enables strict warnings in all CI build steps

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@not-matthias not-matthias force-pushed the cod-1520-compiler-warning-on-v130 branch from 0053960 to 7d17eea Compare October 20, 2025 09:21
@not-matthias not-matthias requested a review from art049 October 20, 2025 09:21
@not-matthias not-matthias force-pushed the cod-1510-bazel-build-is-broken-on-v130 branch from 86049c6 to f615ab6 Compare October 20, 2025 12:45
Base automatically changed from cod-1510-bazel-build-is-broken-on-v130 to main October 20, 2025 13:35
@not-matthias not-matthias force-pushed the cod-1520-compiler-warning-on-v130 branch from 7d17eea to 4a4951f Compare October 20, 2025 13:36
@not-matthias not-matthias merged commit 4a4951f into main Oct 20, 2025
24 of 25 checks passed
@not-matthias not-matthias deleted the cod-1520-compiler-warning-on-v130 branch October 20, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compiler warning on v1.3.0

2 participants