-
Notifications
You must be signed in to change notification settings - Fork 3
fix: compiler warning on v130 #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d3b689e to
36c6db4
Compare
CodSpeed Performance ReportMerging #27 will degrade performances by 32.11%Comparing Summary
Benchmarks breakdown
|
36c6db4 to
f429757
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes compiler warnings on v130 by making strict warning flags (-Wall and -Werror) conditional and only enabling them during CI builds, while maintaining consistency across build systems.
- Introduces conditional strict warning flags that are only enabled in CI environments
- Updates CMake and Bazel build configurations to use synchronized compiler flag lists
- Bumps instrument-hooks submodule to a newer version
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/instrument-hooks | Updates submodule to newer commit |
| core/CMakeLists.txt | Adds conditional strict warnings option and synchronized compiler flags |
| core/BUILD | Implements Bazel equivalent of strict warnings with flag synchronization |
| .github/workflows/ci.yml | Enables strict warnings in all CI build steps |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
0053960 to
7d17eea
Compare
86049c6 to
f615ab6
Compare
7d17eea to
4a4951f
Compare
Fixes #26
Changes in this PR:
-Walland-Werrorin CI