Skip to content

Conversation

@not-matthias
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where measurement_is_instrumented() was being called before measurement_init() initialized the required g_hooks variable. The fix reorders initialization to ensure g_hooks is set up before use.

  • Moved measurement_init() to the beginning of the constructor
  • Changed member initialization from initializer list to constructor body
  • Added a clarifying comment about the initialization order requirement

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 22, 2025

CodSpeed Performance Report

Merging #28 will not alter performance

Comparing cod-1547-codspeed-cpp-fix-unknown-environment-warnings-when-running (7c8c06d) with main (4a4951f)

Summary

✅ 152 untouched

@not-matthias not-matthias merged commit 7c8c06d into main Oct 22, 2025
25 checks passed
@not-matthias not-matthias deleted the cod-1547-codspeed-cpp-fix-unknown-environment-warnings-when-running branch October 22, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants