Skip to content

Conversation

@not-matthias
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a benchmark measurement issue in BenchmarkLargeSetupInLoop where the timer management was incorrectly recording expensive setup operations as part of the benchmark timing, leading to incorrect minimum values. The fix moves timer controls outside the loop and ensures only the actual work is measured.

  • Relocates StopTimer() and ResetTimer() calls before the benchmark loop begins
  • Adds StopTimer() call after measured work to prevent contamination from loop overhead
  • Updates logging configuration to reduce noise from handlebars and dircpy modules

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
go-runner/src/main.rs Changes logging filter levels from Off to Warn for handlebars module and adds a new filter for dircpy module
example/setup_test.go Fixes benchmark timer placement to correctly exclude expensive setup operation from measurements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 14, 2025

CodSpeed Performance Report

Merging #36 will degrade performances by 99.98%

Comparing cod-1688-codspeed-go-micro-benchmark-has-very-large-quantiles (0b914bf) with main (c2e15c1)

Summary

❌ 1 regression
✅ 39 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
BenchmarkLargeSetupInLoop 24 ns 158,271 ns -99.98%

@not-matthias not-matthias force-pushed the cod-1688-codspeed-go-micro-benchmark-has-very-large-quantiles branch from 2f88512 to 0b914bf Compare November 14, 2025 10:40
@not-matthias not-matthias merged commit 0b914bf into main Nov 14, 2025
15 of 16 checks passed
@not-matthias not-matthias deleted the cod-1688-codspeed-go-micro-benchmark-has-very-large-quantiles branch November 14, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants