cod 177 run time based benchmarks in the codspeed runner#39
Merged
adriencaccia merged 6 commits intomainfrom Sep 18, 2024
Merged
Conversation
Member
adriencaccia
commented
Sep 17, 2024
adriencaccia
commented
- refactor(runner): create executor instrument abstraction and add ValgrindInstrument
- feat(runner): add WallTimeInstrument
- feat(runner): add cpu and memory data to SytemInfo
adriencaccia
force-pushed
the
cod-177-run-time-based-benchmarks-in-the-codspeed-runner
branch
from
88a1542 to
38d891e
Compare
fargito
reviewed
Sep 17, 2024
art049
requested changes
Sep 17, 2024
Member
art049
left a comment
art049
left a comment
There was a problem hiding this comment.
I think we need to refactor a bit the executor instrument and even if it might be a big change right now we can keep it for the future instruments
adriencaccia
force-pushed
the
cod-177-run-time-based-benchmarks-in-the-codspeed-runner
branch
from
38d891e to
604e62b
Compare
adriencaccia
force-pushed
the
cod-177-run-time-based-benchmarks-in-the-codspeed-runner
branch
4 times, most recently
from
c31367b to
904a63d
Compare
art049
approved these changes
Sep 18, 2024
…_nodejs to be more specific
adriencaccia
force-pushed
the
cod-177-run-time-based-benchmarks-in-the-codspeed-runner
branch
from
904a63d to
fe62ad6
Compare
adriencaccia
deleted the
cod-177-run-time-based-benchmarks-in-the-codspeed-runner
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.