61 put project #78
Open
61 put project #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yurika-Kan
reviewed
Nov 6, 2025
| if (rawPath.startsWith('/') && rawPath.split('/').length === 2 && method === 'PUT') { | ||
| const id = rawPath.split('/')[1]; | ||
| if (!id) return json(400, { message: 'id is required' }); | ||
| const body = event.body ? JSON.parse(event.body) as Record<string, {name:string, total_budget:number}> : {}; |
Contributor
There was a problem hiding this comment.
i wrote util helper funcs to validate fields bc 1. detailed err messages, 2. ensure data being processed is in correct format, 3. faster performance - its not up in main yet, so probably just note for future work to use those methods to validate fields here!
Yurika-Kan
reviewed
Nov 6, 2025
Contributor
Yurika-Kan
left a comment
Yurika-Kan
left a comment
There was a problem hiding this comment.
good stuff, just a comment on validating fields before trying to put them in & prehandling them before database does!
nourshoreibah
previously approved these changes
Nov 7, 2025
Collaborator
nourshoreibah
left a comment
nourshoreibah
left a comment
There was a problem hiding this comment.
What Yurika said, feel free to steal her data validation things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #61
📝 Description
project/{projectId}nameandtotal_budget✔️ Verification