added delete user route, user settings route tests, and ran prettier #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmullinthomas
requested review from
a team,
florisdobber,
jackblanc and
rymaju
and removed request for
a team
jackblanc
approved these changes
Mar 7, 2021
Member
jackblanc
left a comment
jackblanc
left a comment
There was a problem hiding this comment.
Test needs to get fixed but other than that looks good
| } from '../protectedApiClient'; | ||
| import nock from 'nock'; | ||
|
|
||
| describe('Protected API Client Tests', () => {}); |
Member
There was a problem hiding this comment.
This is failing (see GitHub Actions), can you add one test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Added the delete user route to the frontend scaffold because functionality is shared by all projects
This PR
Added the delete user route to the protectedApiRoutes file and added a test file
Verification Steps
Each of the routes works on sftt and were copied over. npm run check threw no errors