-
Notifications
You must be signed in to change notification settings - Fork 363
feat: Migrate email service from Nodemailer to Resend #1247 #1294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate email service from Nodemailer to Resend #1247 #1294
Conversation
|
@100NikhilBro is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
|
Hi @Avdhesh-Varshney, I’ve updated the setup from Nodemailer to Resend. Please review the changes and let me know if you have any suggestions or improvements. I’ll make the necessary updates before creating the PR. |
Avdhesh-Varshney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the indentation of your editor to be 2-space. This should not be repeated everytime.
|
Hi @Avdhesh-Varshney, sorry for missing the 2-space indentation this time — I’ll make sure to follow it properly next time. 🙏 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Avdhesh-Varshney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved and Working 🎉
Thanks for this amazing contribution 😄
🔧 Resend Email Service Migration
Resolves: #1247
📝 Summary
This pull request completes the migration of our email service from Nodemailer to Resend.
This change addresses deliverability and maintenance concerns discussed in issue #1247 by leveraging Resend's:
⚙️ Changes Implemented
1️⃣ Replaced Email Service
config/nodemailer.jsfile.config/resend.jsservice file that securely initializes the Resend client using an API key.2️⃣ Updated Environment Configuration
ADMIN_EMAILandADMIN_PASSWORDvariables fromconfig/env.js.RESEND_API_KEYvariable to handle authentication with Resend..env.exampleto reflect these new requirements.3️⃣ Refactored Controller Logic
invitationToCollaboratecontroller to use the new Resend service.async/awaitsyntax instead of callbacks, simplifying the code and improving error handling.4️⃣ Added Dependencies
resendtopackage.json..envfile: