Conversation
1cf9b7f to
62c65f4
Compare
|
@Karrp @kbeker @maciejSamerdak @MartynaAnnaGottschling @rwrzesien
|
| DELETE_POPUP_NO = ugettext_lazy("No") | ||
|
|
||
|
|
||
| class TaskActivitiesStrings(Enum): |
There was a problem hiding this comment.
As discussed, it this can ever change I would make it a table, and even create a separate entries from some defaults per each project, so if someone want to change it in single project, it won't have impact on others.
|
PR looks good if you want to keep it with enum, if you want to make it a separate table than I think this is only thing left to do. |
employees/common/strings.py
Outdated
| CODING = ugettext_lazy("Coding") | ||
| MEETING = ugettext_lazy("Meeting") | ||
| TESTING = ugettext_lazy("Testing") | ||
| OTHERS = ugettext_lazy("Others") |
There was a problem hiding this comment.
OTHERS -> OTHER
here and other places ;)
There is a way too many entries. I.e. what's the difference between
|
|
Well, "Graphics" would be nice and "Community work" maybe ;) |
|
62c65f4 to
701ed4e
Compare
4a936df to
c90e7d3
Compare
kbeker
left a comment
There was a problem hiding this comment.
I finished and tested this branch. Merged.
Resolves: #57