Skip to content

Feature tasks activities#111

Merged
kbeker merged 12 commits intomasterfrom
feature-tasks-activities
Apr 23, 2019
Merged

Feature tasks activities#111
kbeker merged 12 commits intomasterfrom
feature-tasks-activities

Conversation

@Szymiks
Copy link
Contributor

@Szymiks Szymiks commented Apr 3, 2019

Resolves: #57

@Szymiks Szymiks self-assigned this Apr 3, 2019
@Szymiks Szymiks added the feature New feature label Apr 3, 2019
@Szymiks Szymiks added this to the tag 0.1.0 milestone Apr 3, 2019
@Szymiks Szymiks force-pushed the feature-tasks-activities branch 3 times, most recently from 1cf9b7f to 62c65f4 Compare April 8, 2019 14:57
@Szymiks
Copy link
Contributor Author

Szymiks commented Apr 10, 2019

@Karrp @kbeker @maciejSamerdak @MartynaAnnaGottschling @rwrzesien
Task activities for this moment:

  • Project Management
  • Meeting
  • Spec & Requirements
  • Design
  • Frontend Development
  • Backend Development
  • QA/Testing,
  • Travel
  • Administrative
  • Marketing
  • Training
  • Mentorship
  • Configuration
  • Deployment
  • Review
  • Research
  • Documentation
  • Other
  • Workshop
    What do you think? Should We have something more or something is not needed.

DELETE_POPUP_NO = ugettext_lazy("No")


class TaskActivitiesStrings(Enum):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, it this can ever change I would make it a table, and even create a separate entries from some defaults per each project, so if someone want to change it in single project, it won't have impact on others.

@rwrzesien
Copy link
Contributor

PR looks good if you want to keep it with enum, if you want to make it a separate table than I think this is only thing left to do.

CODING = ugettext_lazy("Coding")
MEETING = ugettext_lazy("Meeting")
TESTING = ugettext_lazy("Testing")
OTHERS = ugettext_lazy("Others")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OTHERS -> OTHER
here and other places ;)

@dybi
Copy link
Contributor

dybi commented Apr 15, 2019

Task activities for this moment:

* Project Management

* Meeting

* Spec & Requirements

* Design

* Frontend Development

* Backend Development

* QA/Testing,

* Travel

* Administrative

* Marketing

* Training

* Mentorship

* Configuration

* Deployment

* Review

* Research

* Documentation

* Other

* Workshop
  What do you think? Should We have something more or something is not needed.

There is a way too many entries. I.e. what's the difference between

  • Training / Workshop / Mentoring
  • Documentation vs Spec & Requirements and Documentation vs Design vs Research
  • merge Configuration and Deployment into DevOps
  • Also, I would differentiate unambiguously between 'active' and 'passive' activities: i.e attending a training to learn something vs attending a training to teach others soemthing

@wyspiansky87
Copy link

Well, "Graphics" would be nice and "Community work" maybe ;)

@Karrp
Copy link
Contributor

Karrp commented Apr 17, 2019

  • Project Management
  • Meeting
  • Spec & Docs
  • Design & Research
  • Frontend Development
  • Backend Development
  • Quality Assurance / Testing
  • Travel
  • DevOps
  • Review
  • Conference
  • Other
  • Administrative
  • Marketing
  • Training
  • Mentorship
  • Graphic design

@Szymiks Szymiks force-pushed the feature-tasks-activities branch from 62c65f4 to 701ed4e Compare April 18, 2019 10:30
@Szymiks Szymiks requested review from rwrzesien and removed request for rwrzesien April 18, 2019 13:12
@kbeker kbeker force-pushed the feature-tasks-activities branch from 4a936df to c90e7d3 Compare April 23, 2019 20:35
Copy link
Contributor

@kbeker kbeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finished and tested this branch. Merged.

@kbeker kbeker merged commit c90e7d3 into master Apr 23, 2019
@kbeker kbeker deleted the feature-tasks-activities branch April 23, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tasks activities

7 participants