Fix the wrong argument passing when calling PlatformAddress.fromPublic #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joojis
approved these changes
Oct 18, 2019
Contributor
|
I will test and merge it today. |
joojis
reviewed
Oct 18, 2019
src/models/logic/utils/workerpool.ts
Outdated
| return PlatformAddress.fromPublic(signerPubKey, networkId); | ||
| return PlatformAddress.fromPublic(signerPubKey, { | ||
| networkId | ||
| }); |
Contributor
There was a problem hiding this comment.
Oops, toString() is required since it should return string not PlatformAddress.
It was hard to find because this function was called in the worker pool.
joojis
approved these changes
Oct 21, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was hard to find because this function was called in the worker pool.